Do not emit separator before elements for Intersperse on non-fused iterators#152855
Closed
zakarumych wants to merge 1 commit intorust-lang:mainfrom
Closed
Do not emit separator before elements for Intersperse on non-fused iterators#152855zakarumych wants to merge 1 commit intorust-lang:mainfrom
Intersperse on non-fused iterators#152855zakarumych wants to merge 1 commit intorust-lang:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is related to unstable feature
#![feature(iter_intersperse)]#79524
What this does is changes behavior of
Intersperseon nonFusediterators.Particularly in case of iterator that returns
Noneonce fromnextmethod and then proceeds to yield elements normally.Without this change the
Interspersewill also returnNone, but then it will yield separator before first actual element from inner iterator.This change fixes that, so even if underlying iterator starts with
Nones,Interspersewaits for one item to be returned before inserting separators.